Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI #42

Merged
merged 13 commits into from
Nov 7, 2023
Merged

UI #42

merged 13 commits into from
Nov 7, 2023

Conversation

ihkao
Copy link
Contributor

@ihkao ihkao commented Oct 5, 2023

Close #40
In order to test the UI, run the following command:
ros2 run fabric_gui fabric_gui_exe

There are stiil some works to do:
Ploting figure to show histogram and lines of each topics.
Design an UI format for building custom yamls.

To avoid too many lines of code review, I prefer to merge this workable version first.

@LawrenceXu13467
Copy link
Contributor

unable_to_pause
Tested working. However, sometimes I couldn't pause after launching, like the screenshot above.

@ihkao
Copy link
Contributor Author

ihkao commented Oct 11, 2023

The screenshot suggests that you've paused and obtained the measurement result.
You can only activate the pause button after pressing the launch button.
There's a logic in place ensuring that the launch and pause buttons aren't both enabled simultaneously.

@LawrenceXu13467
Copy link
Contributor

LawrenceXu13467 commented Oct 12, 2023

The screenshot suggests that you've paused and obtained the measurement result. You can only activate the pause button after pressing the launch button. There's a logic in place ensuring that the launch and pause buttons aren't both enabled simultaneously.

unable_to_pause
@ihkao Maybe this one? The pause is greyed out right after I hit launch. This happens when I switch rmw.

@ihkao
Copy link
Contributor Author

ihkao commented Oct 13, 2023

Please provide your operation step by step for me to represent your issue.

@LawrenceXu13467 LawrenceXu13467 merged commit 80ae0f6 into upowerrobotics:main Nov 7, 2023
2 of 3 checks passed
@LawrenceXu13467
Copy link
Contributor

Please provide your operation step by step for me to represent your issue.

I've merged as of now. As last time we discussed, the above issue only exists because once we find an available dds, the launch button won't be greyed out for other unavailable dds even if we switch later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create UI
2 participants