fix: remove JSON.stringify for string credential #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceanis
reviewed
May 11, 2023
Comment on lines
218
to
222
| if (typeof cred !== 'string' && cred.proof.jwt) { | ||
| return cred.proof.jwt | ||
| } else { | ||
| return JSON.stringify(cred) | ||
| return cred | ||
| } |
There was a problem hiding this comment.
There are 3 cases here, and we were indeed not handling them properly:
- credential is already a string (JWT). return it directly
- credential is an Object but it's a JwtProof2020 proof, which is only used for convenience. The actual credential is in
cred.proof.jwt, so return that instead - credential is an Object with any other JSON-LD/EIP712 proof. In this case return
JSON.stringify(credential)
The reason for this extra processing is that EIP712 proofs don't support heterogenous objects in an array, so the "quick fix" is to turn them all into strings.
There was a problem hiding this comment.
I updated the PR with separate checks for all 3 cases.
martines3000
force-pushed
the
fix/presentation-creation
branch
from
4f3f998 to
972e97e
Compare
mirceanis
approved these changes
May 12, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this PR fixing
Fixes issue where a credential in string format is encoded as a string twice.
What is being changed
Removes JSON.stringify for string credential.
Quality
Check all that apply:
pnpm i,pnpm build,pnpm test,pnpm test:browserlocally.