Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(credential-ld): remove expired credential from test fixtures. #1177

Merged
merged 1 commit into from
May 15, 2023

Conversation

mirceanis
Copy link
Member

What issue is this PR fixing

This cleans some of the test cases relating to credentials from the wild, leading to test failures for #1175 and #1176

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.

@mirceanis mirceanis requested a review from nickreynolds May 15, 2023 16:54
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 85.55% and project coverage change: +4.89 🎉

Comparison is base (125bf42) 80.25% compared to head (6f852e5) 85.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1177      +/-   ##
==========================================
+ Coverage   80.25%   85.14%   +4.89%     
==========================================
  Files         118      154      +36     
  Lines        4056    15890   +11834     
  Branches      875     1677     +802     
==========================================
+ Hits         3255    13530   +10275     
- Misses        798     2360    +1562     
+ Partials        3        0       -3     
Impacted Files Coverage Δ
packages/core-types/src/coreEvents.ts 100.00% <ø> (ø)
...s/credential-ld/src/module-types/jsonld/index.d.ts 0.00% <0.00%> (ø)
packages/data-store-json/src/data-store-json.ts 91.55% <ø> (+6.44%) ⬆️
...ckages/data-store-json/src/identifier/did-store.ts 92.52% <ø> (+3.16%) ⬆️
...ckages/data-store-json/src/identifier/key-store.ts 86.84% <ø> (+10.37%) ⬆️
...ata-store-json/src/identifier/private-key-store.ts 94.11% <ø> (+5.48%) ⬆️
packages/data-store-json/src/index.ts 100.00% <ø> (ø)
packages/data-store-json/src/types.ts 0.00% <ø> (ø)
packages/data-store/src/data-store-orm.ts 90.39% <ø> (+17.25%) ⬆️
packages/data-store/src/data-store.ts 97.24% <ø> (-0.26%) ⬇️
... and 77 more

... and 67 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mirceanis mirceanis merged commit 13294fa into next May 15, 2023
@mirceanis mirceanis deleted the fix-failing-tests branch May 15, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant