Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile by default with "-g" #19

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 24, 2019

As dpu binaries are small (even with debug information) and lldb is relying a lot on them, I propose to have debug information enable by default.

debug information can be deactivated using -g0

@ghost ghost requested review from vpalatin, JordiChauzi and aghiti December 24, 2019 10:35
Copy link

@JordiChauzi JordiChauzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that this change does not break the current test suite (because of the dpuservice debugger)?
We probably want to remove all -g from the documentation examples and explain why we do not need it in the first example.

@ghost ghost force-pushed the pr/rjodin/debug_by_default branch from 94a681d to 171a4a4 Compare January 2, 2020 12:19
@ghost
Copy link
Author

ghost commented Jan 2, 2020

I have run the test suite with it without any error

@ghost
Copy link
Author

ghost commented Jan 3, 2020

Integrated

@ghost ghost closed this Jan 3, 2020
yberthier pushed a commit that referenced this pull request Jan 29, 2025
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants