Generate dependencies for referenced shared libs #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When packaging python packages that contain shared libraries, they usually link against other external shared libraries. This creates a runtime dependency on other Debian packages. This change will scan all libraries for such dependencies and generate the Debian package dependencies for them.
|
Hello! Any comment why this fix was rejected? |
|
Hello! Looks like the PR was closed automatically when I deleted the master branch :/ I'm trying to clean up the project a little bit. I haven't really looked into your fix but I don't get why dpkg-shlibdeps does not find the dependencies that ldd finds. I need to look into it. I will leave your PR open in the meantime ! |
|
Mmmm can you edit your MR to refer to main instead of master? |
|
Hey, thanks for your quick response! Sure, I will rebase my changes onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When packaging python packages that contain shared libraries, they
usually link against other external shared libraries. This creates a
runtime dependency on other Debian packages.
This change will scan all libraries for such dependencies and
generate the Debian package dependencies for them.
Example with
libvirt-python:before:
Depends: python3 (<< 3.8), python3 (>= 3.7~), python3:anyafter:
Depends: libacl1, libapparmor1, libattr1, libaudit1, libavahi-client3, libavahi-common3, libblkid1, libc6, libcap-ng0, libcom-err2, libcurl3-gnutls, libdbus-1-3, libdevmapper1.02.1, libffi6, libgcc1, libgcrypt20, libgmp10, libgnutls30, libgpg-error0, libgssapi-krb5-2, libhogweed4, libicu63, libidn2-0, libk5crypto3, libkeyutils1, libkrb5-3, libkrb5support0, libldap-2.4-2, liblz4-1, liblzma5, libnettle6, libnghttp2-14, libnl-3-200, libnl-route-3-200, libnuma1, libp11-kit0, libpcre3, libpsl5, librtmp1, libsasl2-2, libselinux1, libssh2-1, libstdc++6, libsystemd0, libtasn1-6, libudev1, libunistring2, libuuid1, libvirt0, libxml2, libyajl2, python3 (<< 3.8), python3 (>= 3.7~), python3:any, zlib1g