skip websocket auth init if initialized #126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
During websocket initialization we overwrote auth context populated from the
request middleware. This is necessary when using the playground as browsers
send only a limited subset of headers when initializing a websocket connection.
However, for programmatic websocket clients that do send auth headers in the
initial upgrade request, the websocket init function was clearing those from
context.
This PR makes auth context initialization from the websocket connection init
function conditional and only runs if auth context wasn't already initialized.
I have:
make reviewable
to ensure this PR is ready for review.Addedbackport release-x.y
labels to auto-backport this PR, as appropriate.How has this code been tested
I'm testing this locally with a programmatic websocket client.