Add crossplaneResourceTree to get a list of all descendantes of a given XRM Resource.
#105
Conversation
XRM Resource. Resovles upbound#95
thephred
force-pushed
the
resource-tree
branch
from
d987d27 to
b518cfd
Compare
There was a problem hiding this comment.
Couldn't you (almost?) write a GraphQL query to get this information with what we have in the schema today using inline fragments? I'm guessing the only blocker is that GraphQL doesn't currently support recursive queries.
Co-authored-by: Nic Cope <nicc@rk0n.org>
You are spot on. We want to be able to get this list and we run into depth limitations and verbose queries. Also it might be reasonable to page the results eventually and this wouldn't make sense in the recursive case. |
thephred
changed the title
xrmResourceTree to get a list of all descendantes of a given XRM Resource.crossplaneResourceTree to get a list of all descendantes of a given XRM Resource.
for composing all `KubernetesResources` (Will be squashed)
| crossplaneResourceTree( | ||
| "The `ID` of an `CrossplaneResource`" | ||
| id: ID! | ||
| ): CrossplaneResourceTreeConnection! | ||
| } |
There was a problem hiding this comment.
I imagine this could also be a field on claims, XRs, etc like children or exploded rather than a distinct query. Would that offer a better or worse UX?
There was a problem hiding this comment.
That would work but it could result in asking for a tree for every object in an array or even worse asking for a tree for every element in a tree. By putting it at a top level we encourage it to be used more conservatively.
Description of your changes
Add
xrmResourceTreeto get a list of all descendantes of a given XRM Resource.Resovles #95
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Ran
makeandmake reviewable