-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate platform reference to Upbound official providers #10
Conversation
Signed-off-by: Yury Tsarev <yury@upbound.io>
Signed-off-by: Yury Tsarev <yury@upbound.io>
Signed-off-by: Yury Tsarev <yury@upbound.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this is on the wrong PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README updates (I can't select these lines in the GitHub UI)
- Should the README include information about image pull secrets?
- In the README Quick start, update the PLATFORM_VERSION environment variable
Testing of resources was successful:
kubectl get claim
kubectl get managedNAME READY CONNECTION-SECRET AGE
cluster.azure.platformref.upbound.io/platform-ref-azure True platform-ref-azure-kubeconfig 12m
NAME READY CONNECTION-SECRET AGE
postgresqlinstance.azure.platformref.upbound.io/platform-ref-azure-db True platform-ref-azure-db-conn 11m
✗ kubectl get managed
NAME READY SYNCED EXTERNAL-NAME AGE
resourcegroup.azure.upbound.io/platform-ref-azure-rg True True platform-ref-azure-rg 12m
NAME CHART VERSION SYNCED READY STATE REVISION DESCRIPTION AGE
release.helm.crossplane.io/platform-ref-azure-prometheus prometheus 15.0.1 True True deployed 1 Install complete 2m21s
NAME READY SYNCED EXTERNAL-NAME AGE
kubernetescluster.containerservice.azure.upbound.io/platform-ref-azure-aks True True platform-ref-azure-aks 12m
NAME READY SYNCED EXTERNAL-NAME AGE
virtualnetworkrule.dbforpostgresql.azure.upbound.io/platform-ref-azure-sn-rule True True platform-ref-azure-sn-rule 11m
NAME READY SYNCED EXTERNAL-NAME AGE
server.dbforpostgresql.azure.upbound.io/platform-ref-azure-postgresql True True platform-ref-azure-postgresql 11m
NAME READY SYNCED EXTERNAL-NAME AGE
virtualnetwork.network.azure.upbound.io/platform-ref-azure-vnet True True platform-ref-azure-vnet 12m
NAME READY SYNCED EXTERNAL-NAME AGE
subnet.network.azure.upbound.io/platform-ref-azure-sn True True platform-ref-azure-sn 12m
Signed-off-by: Yury Tsarev <yury@upbound.io>
@stevendborrelli thanks a ton for the thorough testing. I've made some updated to the README, could you take a look if they make sense? |
Fully comply with https://crossplane.io/docs/v1.9/reference/xpkg.html#object-annotations Signed-off-by: Yury Tsarev <yury@upbound.io>
Signed-off-by: Yury Tsarev <yury@upbound.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for getting this reference platform updated @ytsarev, great work!! 💪
in our testing, we were able to also deploy an app to the AKS cluster that could connect to and consume the postgres database?
@@ -353,7 +278,7 @@ docker login ${REGISTRY} -u ${UPBOUND_ACCOUNT_EMAIL} | |||
Build package. | |||
|
|||
```console | |||
up xpkg build --name platform-ref-azure.xpkg --ignore ".github/workflows/*,examples/*,hack/*" | |||
up xpkg build --name platform-ref-azure.xpkg --ignore ".github/workflows/*,hack/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's awesome that examples get included in the packages now!
version: "1.21.7" | ||
forProvider: | ||
location: West US 2 | ||
kubernetesVersion: "1.24.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a version that has all the server side CRD perf fixes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question, from what I can tell yes, https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.24.md#changelog-since-v1243
The changelog contains kubernetes/kubernetes#111648
Also, it is the highest available AKS version at the moment
az aks get-versions --location westus2 --output table
KubernetesVersion Upgrades
------------------- -----------------------
1.24.3 None available
1.24.0 1.24.3
1.23.8 1.24.0, 1.24.3
1.23.5 1.23.8, 1.24.0, 1.24.3
1.22.11 1.23.5, 1.23.8
1.22.6 1.22.11, 1.23.5, 1.23.8
@jbw976 thanks a lot for the review! The e2e application deployment is not part of this PR as we decided to not expand the scope and focus on the official provider migration only. The platform-ref functionality can be definitely expanded with the next possible incremental iterations. |
Signed-off-by: Yury Tsarev yury@upbound.io
Description of your changes
Concerns
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR, as appropriate.How has this code been tested