Avoid explicit pin of the family provider azure #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This is to avoid dependency conflict situation in the higher level
Configurations like platform-ref-azure
* Before the change currently it ends up in degraded state
```
k get configurations
NAME INSTALLED HEALTHY PACKAGE AGE
platform-ref-azure True True platform-ref-azure-v0.5.0-rc.0.126.g48f317c.gz 31m
upbound-configuration-app True True xpkg.upbound.io/upbound/configuration-app:v0.4.0 31m
upbound-configuration-azure-aks True True xpkg.upbound.io/upbound/configuration-azure-aks:v0.6.0 31m
upbound-configuration-azure-database True Unknown xpkg.upbound.io/upbound/configuration-azure-database:v0.10.0 31m
upbound-configuration-azure-network True True xpkg.upbound.io/upbound/configuration-azure-network:v0.7.0 31m
upbound-configuration-gitops-flux True True xpkg.upbound.io/upbound/configuration-gitops-flux:v0.4.0 30m
upbound-configuration-observability-oss True True xpkg.upbound.io/upbound/configuration-observability-oss:v0.4.0 30m
```
```
k describe configurationrevisions.pkg.crossplane.io upbound-configuration-azure-database-820ed7390759
...
Status:
Conditions:
Last Transition Time: 2024-04-04T10:54:18Z
Message: cannot resolve package dependencies: incompatible dependencies: [xpkg.upbound.io/upbound/provider-family-azure]
Reason: UnknownPackageRevisionHealth
Status: Unknown
Type: Healthy
...
Warning ResolveDependencies 25s (x32 over 30m) packages/configurationrevision.pkg.crossplane.io cannot resolve package dependencies: incompatible dependencies: [xpkg.upbound.io/upbound/provider-family-azure]
```
Some other configurations pulled in the higher version of the family
provider with its implicit pulling mechanism of latest
```
k get providers
NAME INSTALLED HEALTHY PACKAGE AGE
crossplane-contrib-provider-helm True True xpkg.upbound.io/crossplane-contrib/provider-helm:v0.16.0 31m
crossplane-contrib-provider-kubernetes True True xpkg.upbound.io/crossplane-contrib/provider-kubernetes:v0.11.4 31m
grafana-provider-grafana True True xpkg.upbound.io/grafana/provider-grafana:v0.8.0 31m
upbound-provider-azure-containerservice True True xpkg.upbound.io/upbound/provider-azure-containerservice:v0.42.1 32m
upbound-provider-azure-dbformariadb True True xpkg.upbound.io/upbound/provider-azure-dbformariadb:v0.42.1 31m
upbound-provider-azure-dbforpostgresql True True xpkg.upbound.io/upbound/provider-azure-dbforpostgresql:v0.42.1 31m
upbound-provider-azure-network True True xpkg.upbound.io/upbound/provider-azure-network:v0.42.1 31m
upbound-provider-family-azure True True xpkg.upbound.io/upbound/provider-family-azure:v1.0.0 31m
```
and it broke the dependency resolution.
Removing explicit pin should mitigate the issue.
Signed-off-by: Yury Tsarev <yury@upbound.io>
haarchri
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This is to avoid dependency conflict situation in the higher level Configurations like platform-ref-azure
Before the change currently it ends up in degraded state
Some other configurations pulled in the higher version of the family provider with its implicit pulling mechanism of latest
and it broke the dependency resolution.
Removing explicit pin should mitigate the issue.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested