Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Bump version of golangci-lint to v1.51.0 #226

Merged
merged 1 commit into from
Apr 3, 2023
+1 −1
Merged

Bump version of golangci-lint to v1.51.0 #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion makelib/golang.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ endif

# We use a consistent version of golangci-lint to ensure everyone gets the same
# linters.
GOLANGCILINT_VERSION ?= 1.50.1
GOLANGCILINT_VERSION ?= 1.51.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @siredmar! If you are encountering this in a repo you can always override in your parent Makefile by explicitly setting GOLANGCILINT_VERSION as well :) Also, any reason not to go ahead and bump to latest (1.52.2)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the reason for this was the lined version in the issue mentioned above. I didn't test go1.20 with 1.52.2. If you like, you can test it as i don't have the time to test this right now.

GOLANGCILINT := $(TOOLS_HOST_DIR)/golangci-lint-v$(GOLANGCILINT_VERSION)

GO_BIN_DIR := $(abspath $(OUTPUT_DIR)/bin)
Expand Down