Skip to content

Commit

Permalink
Remove macro WHATWG_URL_SPEC_ISSUE_303
Browse files Browse the repository at this point in the history
Because the URL standard fix whatwg/url#343 is
merged.

Tests: web-platform-tests/wpt#7326
  • Loading branch information
rmisev committed Sep 20, 2017
1 parent 313b293 commit 8fe0173
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
8 changes: 0 additions & 8 deletions src/url.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@
#include <vector>


// https://github.com/whatwg/url/issues/303
// https://github.com/whatwg/url/issues/303#issuecomment-298084064
#define WHATWG_URL_SPEC_ISSUE_303 1

namespace whatwg {

// URL class
Expand Down Expand Up @@ -1481,12 +1477,8 @@ inline url_result url_parser::url_parse(url_serializer& urls, const CharT* first
break;

default:
#if WHATWG_URL_SPEC_ISSUE_303
if (base && base->is_file_scheme() &&
!detail::starts_with_Windows_drive(pointer, last)) {
#else
if (base && base->is_file_scheme()) {
#endif
url::str_view_type base_path = base->get_path_first_string(2);
// if base’s path[0] is a normalized Windows drive letter
if (base_path.length() == 2 &&
Expand Down
3 changes: 1 addition & 2 deletions test/tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,8 @@ int main(int argc, char** argv)
err |= test_from_file(run_setter_tests, "w3c-tests/setters_tests.json");


#if WHATWG_URL_SPEC_ISSUE_303
// more tests
err |= test_from_file(run_parser_tests, "w3c-tests/urltestdata--issue-303.json");
#endif

return err;
}
Expand Down

0 comments on commit 8fe0173

Please sign in to comment.