Skip to content

Commit

Permalink
Fix remaining clang-tidy warnings
Browse files Browse the repository at this point in the history
* cppcoreguidelines-pro-bounds-array-to-pointer-decay

* modernize-use-auto
  • Loading branch information
rmisev committed Aug 7, 2024
1 parent a4799a6 commit 1e212ac
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion include/upa/idna/idna_table.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ inline std::size_t apply_mapping(uint32_t val, StrT& output) {
len += ind >> 8;
ind &= 0xFF;
}
output.append(allCharsTo + ind, allCharsTo + ind + len);
const auto* ptr = static_cast<const char32_t*>(allCharsTo) + ind;
output.append(ptr, len);
return len;
}
return 0;
Expand Down
4 changes: 2 additions & 2 deletions src/nfc_table.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ inline std::size_t get_composition_len(std::uint16_t ci) {
}

inline const codepoint_key_val* get_composition_data(std::uint16_t ci) {
return comp_block_data + (ci & 0x7FF);
return static_cast<const codepoint_key_val*>(comp_block_data) + (ci & 0x7FF);
}

// Decomposition data
Expand All @@ -87,7 +87,7 @@ inline std::size_t get_decomposition_len(std::uint16_t di) {
}

inline const char32_t* get_decomposition_chars(std::uint16_t di) {
return decomp_block_data + (di & 0xFFF);
return static_cast<const char32_t*>(decomp_block_data) + (di & 0xFFF);
}

} // namespace normalize
Expand Down
2 changes: 1 addition & 1 deletion src/punycode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ status decode(std::u32string& output, const char32_t* first, const char32_t* las
// Initialize the state:

punycode_uint n = initial_n;
punycode_uint out = static_cast<punycode_uint>(output.length() - len0); // basic code points count
auto out = static_cast<punycode_uint>(output.length() - len0); // basic code points count
punycode_uint i = 0;
punycode_uint bias = initial_bias;

Expand Down

0 comments on commit 1e212ac

Please sign in to comment.