Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented to config.yml under project directory in init command #82

Merged
merged 2 commits into from
Jan 15, 2022

Conversation

JinIgarashi
Copy link
Member

@naogify @miya0001

Description

I have created develop branch for further implementation for v1.0.0.
partially implemented #41.

  • project directory needs to be specified in init command instead of style.yml file name.
  • config.yml will be created under project directory specified.
version: 0.1.2
style:
  yamlPath: ./style.yml
  jsonPath: ./public/style.json
  compactOutput: false
  • updated test for init.ts

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Others ()

Verify the followings

  • Code is up-to-date with the main branch
  • No build errors after npm run build
  • No lint errors after npm run lint
  • No errors on using charites help globally
  • Make sure all the exsiting features working well

Refer to CONTRIBUTING.MD for more details.

@JinIgarashi JinIgarashi added the enhancement New feature or request label Dec 21, 2021
@JinIgarashi JinIgarashi added this to the Version 1.0.0 milestone Dec 21, 2021
@JinIgarashi JinIgarashi self-assigned this Dec 21, 2021
@JinIgarashi JinIgarashi linked an issue Dec 21, 2021 that may be closed by this pull request
@naogify
Copy link
Contributor

naogify commented Jan 5, 2022

@JinIgarashi
LGTM! 👍

@JinIgarashi
Copy link
Member Author

This is just my note for further updating document.

The only change in this PR is to change an argument to <project_dir>.

init [options] <project_dir>

initialize a style JSON

Options:
  -t, --tilejson-urls <tilejson_urls>          an URL for TileJSON. It will create empty layers from vector_layers
                                               property of TileJSON. Please use comma (,) in case multiple
                                               TileJSONs require.
  -m, --metadatajson-urls <metadatajson_urls>  an URL for metadata.json. It will create empty layers from
                                               vector_layers property of metadata.json. Please use comma (,) in
                                               case multiple metadata.json require.
  -c, --composite-layers                       If it is true, a single YAML will be generated with multiple
                                               layers. Default is false.
  -h, --help                                   display help for command

We can update the entire document for version 1.0.0 later once we will complete most of developments instead of updating one by one.

@JinIgarashi JinIgarashi merged commit 550e272 into develop Jan 15, 2022
@JinIgarashi JinIgarashi deleted the implement-config-yaml-in-init-command branch January 15, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

charites init
2 participants