Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Activity Creation #731

Merged
merged 111 commits into from
Sep 7, 2023
Merged

FEAT: Activity Creation #731

merged 111 commits into from
Sep 7, 2023

Conversation

yaya-mamoudou
Copy link
Contributor

@yaya-mamoudou yaya-mamoudou commented Sep 3, 2023 •
edited
Loading

Summary

This PR has the new screens for activity creation and activity details.

Closes #557

Changes

  • New form for Activity Creation
  • Added preview for on the activity form after every step submission
  • New page for Activity details
  • Made changes to the backend to accommodate new fields.
  • modified result logic when user updates an activity

Screenshots

image
image
image
image
image

@yaya-mamoudou
Fixed issue with comment form submitting when empty
18b19b4
@yaya-mamoudou
Add validation of username when creating new creator to make sure use…
092377c 
…rname is not entered as an email
@yaya-mamoudou
Fixed issue with comment form submitting when empty
ed8b162
@yaya-mamoudou
Merge branch 'master' into outreachy-yaya-713
d15ebd7
@yaya-mamoudou
-
d176262
@yaya-mamoudou
Wrap error string with translation method
b848f81
@yaya-mamoudou
Create project creation form and navigation layouts
0027311
@yaya-mamoudou
Fix form spacing and made banner fixed on mobile
e70f62a
@yaya-mamoudou
modify videoInput component so the user can only add either a video o…
44c3fdb 
…r a video link. Not both at the same time
@yaya-mamoudou
Create Rich text editor component
c632372
@yaya-mamoudou
-
7b19899
@yaya-mamoudou
create project in steps and modified project details page
d63be62
@yaya-mamoudou
+
5a3b387
@yaya-mamoudou
removed extra linear gradient on project details page
80481d3
@yaya-mamoudou
add method to display the right message based on current step and cre…
8f00c2e 
…ate mode
@yaya-mamoudou
Add success dialog to project details page after successful project c…
78f25a8 
…reation
@yaya-mamoudou
bypass validation of image and video fields when publish mode is draft
9e8460b
@yaya-mamoudou
Added modal
d560507
@yaya-mamoudou
Create modal component
1402605
@yaya-mamoudou
Add dialogs for step 3 for user to add tags
c2de630
@yaya-mamoudou
Add confetti to successfull project creation dialog
7f8236d
@yaya-mamoudou
refactored the dropdown component to allow maximum selection when the…
cb7bc42 
… multiple prop is set and also add checkboxes when the withCheckbox property is set
@yaya-mamoudou
Add query to exclude a project in the list of projects of a creator
0782e4f
@yaya-mamoudou
Add more projects to project details page
1654bd4
@yaya-mamoudou
Currently, the email gets displayed on the user profile. (unstructure…
fa46437 
…dstudio#714)

* Fixed issue with comment form submitting when empty

* Add validation of username when creating new creator to make sure username is not entered as an email

* Fixed issue with comment form submitting when empty

* -

* Wrap error string with translation method
@yaya-mamoudou
+
b6d861a
@yaya-mamoudou
validate multiple categories
5533093
@yaya-mamoudou
refactor sidenav
6390d9f
@yaya-mamoudou
Add project mode selection page
c007fea
@yaya-mamoudou
+
613d261
@yaya-mamoudou yaya-mamoudou added feature client Frontend issue api backend issue Outreachy labels Sep 3, 2023
@yaya-mamoudou yaya-mamoudou self-assigned this Sep 3, 2023
@tuxology
Copy link
Member

tuxology commented Sep 4, 2023 •
edited by yaya-mamoudou
Loading

@yaya-mamoudou Thanks for this PR! Most stuff works well 🎉 I am listing some TODOs here that still need some fixing/adjustment

Blockers

  • "Download PDF" button is not working

Bugs/Improvements

  • Clicking on photos not bring up modal
  • Increase min height of images in each step/introduction - it's too thin right now - if a single or two images are added, they look cropped
  • Categories, Class Grade "tags" are buttons - it seems they are clickable. We should change that to be not clickable and non hover able. This is observed in Project tags and categories as well
  • /activities URL takes you to activities list but not enough padding there. We could add a empty div with padding for this section and then place the activities component there?

tuxology
tuxology approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@tuxology tuxology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though general flow is ok and blockers are removed, there is a lot of dead-code and comments left. We need to remove it later. Approving and merging this for now.

@tuxology tuxology merged commit baf7051 into unstructuredstudio:master Sep 7, 2023
iamhks added a commit to iamhks/zubhub that referenced this pull request Sep 9, 2023
@iamhks
Merge pull request #2 from iamhks/master
f4eba11 
Activity Creation Revamp (unstructuredstudio#731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuxology tuxology tuxology approved these changes

@NdibeRaymond NdibeRaymond Awaiting requested review from NdibeRaymond NdibeRaymond is a code owner

Assignees

@yaya-mamoudou yaya-mamoudou

Labels
api backend issue client Frontend issue feature Outreachy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the UI/UX for activity and project creation features for ZubHub
2 participants
@yaya-mamoudou @tuxology