Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labels for publish type corrected #695

Closed
wants to merge 1 commit into from

Conversation

darechan
Copy link
Contributor

Summary

The label for publish type was named incorrectly so as per the discussion in this thread the labeling was corrected

Closes #581

Screenshots

  1. When the project is set to only me it moves to draft
    image
    image

  2. When the project is set to All registered zubhub users
    image
    image

  3. When the project is set to Only a few zubhub users
    image

@iamhks
Copy link
Contributor

iamhks commented Mar 20, 2023

Isn't this PR a duplicate of @cherish2003's https://github.com/unstructuredstudio/zubhub/pull/678/files?

@darechan
Copy link
Contributor Author

Isn't this PR a duplicate of @cherish2003's https://github.com/unstructuredstudio/zubhub/pull/678/files?

This is for #581

@iamhks
Copy link
Contributor

iamhks commented Mar 21, 2023

Isn't this PR a duplicate of @cherish2003's https://github.com/unstructuredstudio/zubhub/pull/678/files?

This is for #581

That means the issue itself is a combined duplicate of #592 and #593

@tuxology
Copy link
Member

@iamhks you are correct. The real improvement I was expecting from #581 was improving and building upon #556 which would require more deeper work and UX. For now, we will go with merging wither this PR or #678 just to keep the quick fix going. @darechan We will close this PR and #581 once we merge either of these small fixes.

@tuxology
Copy link
Member

@darechan I am closing this as we just went ahead with the simple fix by @cherish2003 in #699 Thanks for reporting. I think lets keep #581 alive until we find a roper UX for resolving the issue properly

@tuxology tuxology closed this Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draft projects should not show up in the search bar for user who created it
3 participants