Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): Creator profile gets margin #1008

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

brrkrmn
Copy link
Collaborator

@brrkrmn brrkrmn commented Dec 8, 2023

Summary

Creator profile content lacked margin in the following instances:

  1. for non-logged-in users
  2. for logged-in users between 740-960px of screen width

Closes #1005

Changes

  • For logged-in users, the profile content is rendered within a grid inside DashboardLayout, whose styles determine the margins around this content. But in the non-logged-in state, the profile content is rendered on its own. That is why non-logged-in users do not see those margins. However, applying the necessary margins to the content itself results in too much margin for the logged-in state (content's margin + dashboardLayout's margin). That's why I created a new nonLoggedInRoot class or the content to only apply margin for non-logged-in state.
  • Removed margins of separate sections and applied margin to the content's root instead.

Screenshots

Before

image

After

image

@brrkrmn brrkrmn marked this pull request as ready for review December 11, 2023 10:32
@NdibeRaymond
Copy link
Collaborator

code looks good. I haven't tested it manually yet

@NdibeRaymond NdibeRaymond added code-reviewed create-test-vm this issue needs a test vm to be auto created by github action labels Feb 2, 2024
Copy link

github-actions bot commented Feb 9, 2024

@NdibeRaymond is creating a test VM for this PR 🚀🚀🚀
This may take a few minutes so relax and grab a cup of coffee ☕
We will notify you when the VM is ready.

Copy link

github-actions bot commented Feb 9, 2024

Test VM is ready ✅✅✅
You can access it with the url:
https://zubhub-test-1008.unstructured.studio

@NdibeRaymond NdibeRaymond removed the create-test-vm this issue needs a test vm to be auto created by github action label Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

@NdibeRaymond is deleting test VM ...

Copy link

github-actions bot commented Feb 9, 2024

Test VM deleted ✅✅✅

Copy link

pre-commit checks failed ❌❌❌
make sure you have pre-commit set up locally (see the README.md for instructions).
If you have set up pre-commit locally, you may need to undo this commit and
run "pre-commit" locally to see what the errors are.

Copy link

All pre-commit checks passed ✅✅✅

@NdibeRaymond
Copy link
Collaborator

@brrkrmn I already rebased this on top of master and got pre-commit passing.
the steps are:

  • rebase this branch on top of master.
  • squash the commits in this PR from 2 commits to 1.
  • undid the commit in a way that the changes weren't discarded (git reset --soft HEAD~1)
  • followed the instruction in the readme to set up pre-commit
  • run pre-commit to see what the errors were
  • fix the errors, commit and force push

@NdibeRaymond NdibeRaymond changed the base branch from master to staging May 19, 2024 04:34
@NdibeRaymond NdibeRaymond force-pushed the non-logged-in-ui-fixes branch 2 times, most recently from 4358801 to efcab57 Compare May 19, 2024 04:55
Copy link

All pre-commit checks passed ✅✅✅

@NdibeRaymond
Copy link
Collaborator

had to rework this PR a bit. I think it's ok now. merging after pre-commit has completed successfully

Copy link

All pre-commit checks passed ✅✅✅

@yokwejuste
Copy link
Collaborator

had to rework this PR a bit. I think it's ok now. merging after pre-commit has completed successfully

okay...

* fix creator profile margin
* fix projects section margin
* fix wider project css issues
* fix eslint issues

Closes #1005
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
Copy link

All pre-commit checks passed ✅✅✅

@NdibeRaymond
Copy link
Collaborator

more css and eslint fixes

@NdibeRaymond NdibeRaymond merged commit 8b75876 into staging May 21, 2024
5 checks passed
NdibeRaymond pushed a commit that referenced this pull request May 29, 2024
* fix creator profile margin
* fix projects section margin
* fix wider project css issues
* fix eslint issues

Closes #1005
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>

Co-authored-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
NdibeRaymond pushed a commit that referenced this pull request Jul 17, 2024
* fix creator profile margin
* fix projects section margin
* fix wider project css issues
* fix eslint issues

Closes #1005
Signed-off-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>

Co-authored-by: Ndibe Raymond Olisaemeka <rolisaemeka-ctr@wikimedia.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creator profile is stretched for non-logged-in users
3 participants