This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Support Swift 5.7 dependencies #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giginet
commented
Aug 18, 2022
| @@ -106,6 +109,28 @@ struct Zipper { | |||
| func clean (file: Foundation.URL) throws { | |||
| try FileManager.default.removeItem(at: file) | |||
| } | |||
|
|
|||
| #if swift(>=5.7) | |||
| private func checksum(forBinaryArtifactAt path: AbsolutePath) throws -> String { | |||
There was a problem hiding this comment.
checksum(forBinaryArtifactAt:) is moved from Workspace to Workspace.BinaryArtifactsManager.
Unfortunately, workspace.binaryArtifactsManager is concealed from externals.
So I ported the same implementation from the original SwiftPM codes.
giginet
commented
Aug 18, 2022
| @@ -23,7 +23,7 @@ struct ProjectGenerator { | |||
|
|
|||
| var projectPath: AbsolutePath { | |||
| let dir = AbsolutePath(self.package.projectBuildDirectory.path) | |||
| return buildXcodeprojPath(outputDir: dir, projectName: self.package.manifest.displayName) | |||
| return XcodeProject.makePath(outputDir: dir, projectName: self.package.manifest.displayName) | |||
There was a problem hiding this comment.
This global method is moved to a static method.
|
Thanks very much for raising this PR! The code itself looks fantastic to me, I'll run some tests here on my end as well but assuming CI passes we should be good to merge this pretty much straight away. |
|
Thanks very much for the PR! I appreciate the time you took to annotate your PR as well – the notes and reasoning made it a really easy one to review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Since Xcode 14.0 beta 5, swift-tools-support-core@release/5.6 doesn't build due to broken compatibilities.
I updated
swift-tools-support-coreandswift-package-managertorelease/5.7.This PR makes this project enable to build with the latest Xcode. (above Xcode 14 beta 5).
Description
Due to updated dependencies, some APIs are changed. So I changed some implementations.
Unfortunately, GitHub Action doesn't support the latest Xcode yet. So we can't update CI stacks.