Ignore slashes after the protocol for special URLs #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have to add tests but it should work. |
|
LGTM when additional tests are added. |
lpinca
force-pushed
the
ignore/slashes-for-special-urls
branch
from
04db85c
to
320a8dc
Compare
lpinca
changed the title
lpinca
commented
Jul 23, 2021
|
In addition to #208 (comment) and #208 (comment) there are a lot of other inconsistencies with the Node.js WHATWG URL parser. I don't think it's possible to fix all of them without adding a lot of complexity. It is probably easier to rewrite |
Set it to `true` only if the protocol is special or if it is actually followed by two forward slashes.
If the value of the `pathname` property does not start with a `/`, add it only if the URL is special.
|
@3rd-Eden I'm merging this. Can you please cut a new release? |
lpinca
added a commit
that referenced
this pull request
Jul 25, 2021
lpinca
added a commit
that referenced
this pull request
Jul 25, 2021
3rd-Eden
pushed a commit
that referenced
this pull request
Jul 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #205
Fixes #206