Skip to content

Commit

Permalink
fix: set directives default to false
Browse files Browse the repository at this point in the history
  • Loading branch information
hannoeru committed Oct 27, 2021
1 parent 39aecd8 commit e0c9aaf
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -286,10 +286,9 @@ Components({
globalNamespaces: [],

// auto import for directives
// default: `true` for Vue 3, `false` for Vue 2
// Babel is needed to do the transformation for Vue 2, it's disabled by default for performance concerns.
// To install Babel, run: `npm install -D @babel/parser @babel/traverse`
directives: true,
directives: false,

// filters for transforming targets
include: [/\.vue$/, /\.vue\?vue/],
Expand Down
6 changes: 2 additions & 4 deletions src/core/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { isPackageExists } from 'local-pkg'
import { ResolvedOptions, Options } from '../types'
import { LibraryResolver } from './helpers/libraryResolver'

export const defaultOptions: Omit<Required<Options>, 'include' | 'exclude' | 'transformer' | 'globs' |'directives'> = {
export const defaultOptions: Omit<Required<Options>, 'include' | 'exclude' | 'transformer' | 'globs'> = {
dirs: 'src/components',
extensions: 'vue',
deep: true,
Expand All @@ -19,6 +19,7 @@ export const defaultOptions: Omit<Required<Options>, 'include' | 'exclude' | 'tr
importPathTransform: v => v,

allowOverrides: false,
directives: false,
}

export function resolveOptions(options: Options, root: string): ResolvedOptions {
Expand Down Expand Up @@ -58,9 +59,6 @@ export function resolveOptions(options: Options, root: string): ResolvedOptions
)
resolved.root = root
resolved.transformer = options.transformer || getVueVersion() || 'vue3'
resolved.directives = (typeof options.directives === 'boolean')
? options.directives
: getVueVersion() === 'vue3'

return resolved
}
Expand Down
5 changes: 2 additions & 3 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,9 @@ export interface Options {
/**
* auto import for directives.
*
* default: `true` for Vue 3, `false` for Vue 2
*
* Babel is needed to do the transformation for Vue 2, it's disabled by default for performance concerns.
* @default undefined
* To install Babel, run: `npm install -D @babel/parser @babel/traverse`
* @default false
*/
directives?: boolean
}
Expand Down

0 comments on commit e0c9aaf

Please sign in to comment.