Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: class typo #97

Merged
merged 2 commits into from
Oct 2, 2023
Merged

fix: class typo #97

merged 2 commits into from
Oct 2, 2023

Conversation

MuhammadM1998
Copy link
Contributor

Fixes #96

zernonia
zernonia requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized the typo happen in apps/www/src/lib/registry/new-york/ui/avatar/index.ts too. Let's change it too ya!

@MuhammadM1998
Copy link
Contributor Author

They are on these paths too. Are those automatically generated or should we change it too?
apps/www/src/public/registry/styles/default/avatar.json
apps/www/src/public/registry/styles/new-york/avatar.json

@zernonia
Copy link
Member

zernonia commented Oct 2, 2023

those .json are generated automatically. so need not to change those

zernonia
zernonia approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zernonia zernonia merged commit e0cecc3 into unovue:dev Oct 2, 2023
@zernonia
Copy link
Member

zernonia commented Oct 2, 2023 •
edited
Loading

thanks for your contribution @mukundshah 😁

@MuhammadM1998 MuhammadM1998 deleted the patch-1 branch October 2, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zernonia zernonia zernonia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Typo in tailwind classes
2 participants
@MuhammadM1998 @zernonia