Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): add sidebar (Javascript) #1026

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix(sidebar): add sidebar (Javascript) #1026

merged 1 commit into from
Feb 14, 2025

Conversation

4m1n0s
Copy link
Contributor

@4m1n0s 4m1n0s commented Feb 2, 2025

πŸ”— Linked issue

This PR fix the following issue: #929

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Just removing the inline comments, that were preventing "SidebarGroupAction.vue, SidebarMenuAction.vue" to compile to Javascript

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@4m1n0s 4m1n0s changed the title [fix] add sidebar (Javascript) fix(sidebar): add sidebar (Javascript) Feb 2, 2025
@erikgall
Copy link

This fixed the issue for our project! Can we get this PR merged?

@sadeghbarati sadeghbarati merged commit efc4e9f into unovue:dev Feb 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants