Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(useForwardProps): accept MaybeRefOrGetter payload #628

Conversation

zernonia
Copy link
Member

No description provided.

@zernonia
Copy link
Member Author

@sadeghbarati could you help me test that this works? 😁

you can clone this repo, pnpm i && pnpm build, then in your shadcn-vue folder link to radix-vue/packages/radix-vue

@sadeghbarati
Copy link
Collaborator

@zernonia

I tried pnpm i & pnpm build and then npm/pnpm pack instead and uploaded the .tgz file into StackBlitz Playground but it still not working

https://stackblitz.com/edit/hzbqdk?file=package.json,src%2Fcomponents%2Fui%2Fpin-input%2FPinInput.vue

@zernonia
Copy link
Member Author

hmmm... it works right? using const forwarded = useForwardPropsEmits(delegatedProps, emits)

https://stackblitz.com/edit/hzbqdk-wymgqp?file=src%2Fcomponents%2Fui%2Fpin-input%2FPinInput.vue

@sadeghbarati
Copy link
Collaborator

sadeghbarati commented Jan 19, 2024

Aha I used delegatedProps.value that's why it didn't worked

@zernonia zernonia merged commit 5ba578b into main Jan 19, 2024
2 checks passed
@sadeghbarati sadeghbarati deleted the 623-bug-useforwardprops-useforwardpropsemits-should-accept-reactive-props branch June 26, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: useForwardProps, useForwardPropsEmits should accept reactive props
2 participants