Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove duplicate analyzers #9592

Merged
merged 1 commit into from
Aug 25, 2022
Merged

fix: Remove duplicate analyzers #9592

merged 1 commit into from
Aug 25, 2022

Conversation

jeromelaban
Copy link
Member

GitHub Issue (If applicable): #9562

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

Applies a workaround for duplicate analyzers issue introduced around dotnet/wpf#6792

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@gitpod-io
Copy link

gitpod-io bot commented Aug 25, 2022

@nventive-devops
Copy link
Contributor

The build 52791 found UI Test snapshots differences: android-28-xamarin: 0, android-28-xamarin-Snap: 0, ios: 48, ios-Snap: 100, macOS-screenshots: 43, skia-gtk-screenshots: 9, skia-wpf-screenshots: 7, wasm: 15, wasm-automated-net5.0-Benchmarks: 0, wasm-automated-net5.0-Default: 6, wasm-automated-net5.0-RuntimeTests: 0

Details

  • android-28-xamarin: 0 changed over 0

  • android-28-xamarin-Snap: 0 changed over 0

  • ios: 48 changed over 296

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • FlyoutTest_Target_Uno_UI_Samples_Content_UITests_Flyout_Flyout_Target
    • Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
    • PasswordBox_RevealInScrollViewer_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll
    • Screenshots_Image_Stretch_Algmnt_Inf_Horizontal_Mode-1
    • Screenshots_Image_Stretch_Algmnt_Inf_Horizontal_Mode-2
    • Screenshots_Image_Stretch_Alignment_Equal_Mode-3
    • Screenshots_Image_Stretch_Alignment_SizeOnControl_Mode-1
    • Screenshots_Image_Stretch_Alignment_SizeOnControl_Mode-2
    • TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
    • ContentPresenter_Template_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Template
    • Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
    • ListView_ObservableCollection_Creation_Count_Added
    • ListView_ObservableCollection_Creation_Count_Added_above
    • ListView_ObservableCollection_Creation_Count_Removed_above
    • Screenshots_Image_Stretch_Alignment_Bigger_Mode-3
    • Screenshots_Image_Stretch_Alignment_Equal_Mode-0
    • Screenshots_Image_Stretch_Alignment_Equal_Mode-1
    • Screenshots_Image_Stretch_Alignment_Equal_Mode-2
    • Screenshots_Image_Stretch_Alignment_Smaller_Mode-3

  • ios-Snap: 100 changed over 983

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
    • Brushes_UITests_Windows_UI_Xaml_Media_GradientBrushTests_LinearGradientBrush_Change_Stops_UITests_Windows_UI_Xaml_Media_GradientBrushTests_LinearGradientBrush_Change_Stops
    • Animations_DoubleAnimation_TranslateX_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_TranslateX
    • Border_Border_Simple_with_Opacity_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_with_Opacity
    • Brushes_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY
    • Brushes_ImageBrushWithCompositeTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithCompositeTransform
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInList_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInList
    • ComboBox_ComboBox_NoDataContext_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_NoDataContext
    • ComboBox_ComboBox_Picker_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Picker
    • ComboBox_ComboBox_PlaceholderText_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_PlaceholderText
    • Border_NonUniformThicknessandRadius_Uno_UI_Samples_UITests_BorderTestsControl_NonUniformThicknessandRadius
    • Brushes_ImageBrushWithLateSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithLateSource
    • ComboBox_ComboBox_ScrollViewer_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ScrollViewer
    • ComboBox_ComboBox_SelectedIndex_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_SelectedIndex
    • ComboBox_ComboBox_SelectedItem_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_SelectedItem
    • ComboBox_ComboBox_ToggleDisabled_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ToggleDisabled
    • Border_Border_Simple_No_Background_With_Content_Border_With_Background_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_No_Background_With_Content_Border_With_Background
    • Buttons_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping
    • ComboBox_ComboBox_ItemsSource_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ItemsSource

  • macOS-screenshots: 43 changed over 1056

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Animations-BeginTime_MultipleAnimations.png
    • Buttons-SplitButtonPage.png
    • ColorPicker-WinUIColorPickerPage.png
    • BreadcrumbBar-BreadcrumbBarPage.png
    • Grid-CenteredGridinGridwiththreefixedsizechildren.png
    • Image-Image_Stretch_None_ScrollViewer.png
    • Info-InfoBarPage.png
    • Image-Image_Fixed_Size_Alignment.png
    • Image-Image_Formats.png
    • MediaPlayerElement-Using .flv.png
    • Focus-GetFocus.png
    • Image-Image_Stretch_Alignment_SizeOnControl.png
    • MUX-InfoBarPage.png
    • MUX-NavigationViewCustomThemeResourcesPage.png
    • ListView-ListViewIncrementalLoading.png
    • ListView-ListView_With_ListViews_Count_Measure.png
    • MUX-TabViewPage.png
    • MUX-WinUIColorPickerPage.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png

  • skia-gtk-screenshots: 9 changed over 1048

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • DragAndDrop-DragDrop_TestPage.png
    • Image-UniformToFill100x100.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Progress-WindowsProgressRing_GH1220.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • Transform-TransformToVisual_Translate2d.png

  • skia-wpf-screenshots: 7 changed over 1048

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Automation-AutomationProperties_Name.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Progress-WindowsProgressRing_GH1220.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png

  • wasm: 15 changed over 991

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_Features
    • MUXControlsTestApp.PipsPagerPage
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
    • UITests.Microsoft_UI_Xaml_Controls.ImageIconTests.ImageIconPage
    • UITests.Shared.Microsoft_UI_Xaml_Controls.ColorPickerTests.WinUIColorPickerPage
    • UITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_Name
    • UITests.Windows_UI_Xaml.DragAndDrop.DragDrop_TestPage
    • UITests.Windows_UI_Xaml_Controls.ProgressRing.WindowsProgressRing_GH1220
    • UITests.Windows_UI_Xaml_Shapes.Offscreen_Shapes
    • Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Equal
    • Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Smaller
    • Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Taller
    • Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Wider
    • Uno.UI.Samples.UITests.ImageBrushTestControl.Ellipse
    • Uno.UI.Samples.Samples.Shared.Content.UITests.ImageBrushInList

  • wasm-automated-net5.0-Benchmarks: 0 changed over 1

  • wasm-automated-net5.0-Default: 6 changed over 877

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Screenshots_Image_Stretch_Algmnt_Inf_Vertical_Mode-0
    • TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • ListView_Weird_Measure_During_Arrange_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Weird_Measure
    • When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_TransformToVisual_ScrollViewer_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_ScrollViewer

  • wasm-automated-net5.0-RuntimeTests: 0 changed over 1

@MartinZikmund MartinZikmund merged commit bbe8f83 into master Aug 25, 2022
@MartinZikmund MartinZikmund deleted the dev/jela/wpf-workaround branch August 25, 2022 06:26
@jeromelaban
Copy link
Member Author

@Mergifyio backport release/stable/4.4

@mergify mergify bot mentioned this pull request Aug 25, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2022

backport release/stable/4.4

✅ Backports have been created

jeromelaban added a commit that referenced this pull request Aug 25, 2022
@jeromelaban
Merge pull request #9599 from unoplatform/mergify/bp/release/stable/4…
8db593d 
….4/pr-9592

fix: Remove duplicate analyzers (backport #9592)
@lindexi lindexi mentioned this pull request Aug 27, 2022
Closed
@inforithmics
Copy link

inforithmics commented Sep 24, 2022 •
edited
Loading

Microsoft has now fixed this and I have upgraded to uno.ui 4.5.9 and the same errors still occurs. Could it be that the workaround cause the problem to appear again.

Mapsui/Mapsui#1721 (Upgrad 4.5.9 remove wpf duplicate analyzer workaround).

Workaround is following in global.json you have to pin the Version to 6.0.400 then it works with 6.0.401 it doesn't work anymore Maybe when the version is bigger or equal 6.0.401 the workaround has to be disabled.

{
"sdk": {
"allowPrerelease": false,
"version": "6.0.400",
"rollForward": "disable"
},

@inforithmics inforithmics mentioned this pull request Sep 25, 2022
Merged
@jeromelaban
Copy link
Member Author

That's right, we're in the process of publishing an update (4.5.12) which removes the workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpinedam ajpinedam ajpinedam approved these changes

@MartinZikmund MartinZikmund MartinZikmund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeromelaban @nventive-devops @inforithmics @MartinZikmund @ajpinedam