Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump to 9.0.200 #19592

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

chore: Bump to 9.0.200 #19592

wants to merge 25 commits into from

Conversation

MartinZikmund
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/code-generation Categorizes an issue or PR as relevant to code generation label Feb 25, 2025
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19592/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19592/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 156172 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund self-assigned this Feb 25, 2025
@unodevops
Copy link
Contributor

⚠️⚠️ The build 156202 has failed on Uno.UI - CI.

Copy link
Contributor

@ajpinedam ajpinedam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@unodevops
Copy link
Contributor

⚠️⚠️ The build 156251 has failed on Uno.UI - CI.

@github-actions github-actions bot added platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform labels Feb 27, 2025
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19592/index.html

2 similar comments
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19592/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19592/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19592/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19592/index.html

2 similar comments
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19592/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19592/index.html

@jeromelaban jeromelaban changed the title feat: Update Microsoft.CodeAnalysis chore: Bump to 9.0.200 Mar 5, 2025
@github-actions github-actions bot added the area/build Categorizes an issue or PR as relevant to build infrastructure label Mar 5, 2025
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19592/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19592/index.html

@jeromelaban jeromelaban force-pushed the dev/mazi/codeanalysis branch from 4a9aee6 to ddc60d8 Compare March 5, 2025 16:02
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19592/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19592/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19592/index.html

@Youssef1313
Copy link
Member

@jeromelaban I assume this is the update you referred to for fixing Wasm UI tests, but I see the test host is still crashing here.

Test Run Aborted.
Total tests: Unknown
     Passed: 13
     Failed: 6
    Skipped: 61
 Total time: 3.9866 Minutes

So the update doesn't seem to fix it?

@jeromelaban
Copy link
Member

No, and it seems to have started from #18267, curiously. It may not be the PR itself, could also be and change in the hosted agents, somehow.

@jeromelaban
Copy link
Member

jeromelaban commented Mar 6, 2025

I rebuilt the merge commit before #18267, and it's building and testing properly. This means that there's something in that PR that broke the app and/or the test engine, somehow. I'm still trying to find out what.

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19592/index.html

@jeromelaban
Copy link
Member

So it looks like the --filter syntax has changed and that there were many more tests that were running that should have been. I've adjusted a bit the syntax, and it's not failing anymore.

There's another problem related to the default size of the browser, but this is related to the update of selenium/chromium, and that will be fixed in a separate change.

@Youssef1313
Copy link
Member

Youssef1313 commented Mar 6, 2025

@jeromelaban Hmm, I'm not aware of any changes in filter syntax. If you are referring to the Namespace part (which you changed to FullyQualifiedName instead), it's supposed to work as the generator defines that property:

builder.AppendLineIndented($"[global::NUnit.Framework.Property(\"Namespace\", \"{type.ContainingNamespace}\")]");

But yeah, with my PR to migrate to MTP, I noticed there that something with regards the filter feels like it's not working as expected.

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19592/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19592/index.html

@jeromelaban
Copy link
Member

@Youssef1313 Given my last change, which rollback to Namespace in the filter, the build is now failing again.

@Youssef1313
Copy link
Member

It might be worth reporting to NUnit then.

@Youssef1313
Copy link
Member

@jeromelaban fwiw, filtering using Namespace is done also for iOS and Android. It may be worth validating whether or not it's working as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure area/code-generation Categorizes an issue or PR as relevant to code generation platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants