Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensuring that we use lowercase when looking at the env variable values #535

Merged
merged 1 commit into from
Nov 12, 2018
Merged

ensuring that we use lowercase when looking at the env variable values #535

merged 1 commit into from
Nov 12, 2018

Conversation

julien51
Copy link
Member

No description provided.

@julien51 julien51 requested a review from benwerd November 12, 2018 21:41
@julien51
Copy link
Member Author

Note: env vars are lowercase in node: nodejs/node#9157

@julien51
Copy link
Member Author

👋 @benwerd

benwerd
benwerd approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@benwerd benwerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - sorry I somehow overlooked this!

@julien51 julien51 merged commit c9ddc8c into master Nov 12, 2018
@julien51 julien51 deleted the fixingEnv branch November 12, 2018 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwerd benwerd benwerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien51 @benwerd