implement instant return from sendTransaction #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cellog
commented
May 10, 2019
| * | ||
| * See https://github.com/ethers-io/ethers.js/issues/511 | ||
| */ | ||
| export default class FastJsonRpcSigner extends ethers.Signer { |
There was a problem hiding this comment.
This file is tested by the existing tests. If it changed behavior at all, they would fail (and did for many attempts in testing until I got the thing right)
cellog
commented
May 10, 2019
| @@ -135,7 +137,9 @@ export default class UnlockService extends EventEmitter { | |||
| } | |||
|
|
|||
| async getWritableContract(address, contract) { | |||
| const signer = this.provider.getSigner() | |||
| // TODO: replace this when v5 of ethers is out | |||
There was a problem hiding this comment.
this is the first important change to see
cellog
commented
May 10, 2019
| @@ -105,7 +105,8 @@ export default class WalletService extends UnlockService { | |||
| transactionType, | |||
| 'submitted' | |||
| ) | |||
| return transaction.hash | |||
There was a problem hiding this comment.
and the other important change to see
cellog
commented
May 10, 2019
| @@ -79,6 +79,7 @@ describe('v0', () => { | |||
| // verify that the promise passed to _handleMethodCall actually resolves | |||
| // to the result the chain returns from a sendTransaction call to createLock | |||
| const result = await mock.mock.calls[0][0] | |||
| await result.wait() | |||
There was a problem hiding this comment.
all the tests are adjusted for the double wait (would be unnecessary if we weren't testing implementation details, it might be good to remove this test of the mocking, perhaps for a follow-up PR)
cnasc
approved these changes
May 10, 2019
|
Great idea, I'll talk to Julien about this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for upgrading to 0.0.25, it turned out that the default behavior of ethers contract transaction-based method calls does not return the hash until the first mined block. This is between 5-20 seconds on mainnet. Based on discussions with the maintainer of ethers, found in ethers-io/ethers.js#511, this PR implements a new
Signerthat wraps the built-in one, but extends the behavior ofsendTransactionto return right away.In testing, it solves the delay.
As version 5 of ethers is due out soon and includes a first-class citizen
UncheckedJsonRpcSignerthat does this same thing, this is a temporary fix.Checklist: