fix: Keep existing wireit commands

unlight · Jul 29, 2022 · 7ffb449 · 7ffb449
1 parent 01ccbc8
commit 7ffb449
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 11 deletions.
diff --git a/packages/wireit-package/src/index.spec.ts b/packages/wireit-package/src/index.spec.ts
@@ -192,3 +192,45 @@ describe('sequence', () => {
     });
   });
 });
+
+describe('existing wireit', () => {
+  before(() => {
+    const volume = {
+      '/root/package.json': JSON.stringify({
+        workspaces: ['packages/*'],
+      }),
+      '/root/packages/a/package.json': JSON.stringify({
+        name: 'a',
+      }),
+      '/root/packages/b/package.json': JSON.stringify({
+        name: 'b',
+        dependencies: { a: '*' },
+        wireit: {
+          clean: {
+            command: 'rm *',
+          },
+        },
+      }),
+    };
+    mockFs(volume);
+  });
+
+  after(() => {
+    mockFs.restore();
+  });
+
+  it('update', async () => {
+    await update({
+      command: 'npm run build',
+      name: 'build',
+      cwd: '/root',
+    });
+
+    const b = fs.readFileSync('/root/packages/b/package.json').toString();
+    const { wireit } = JSON.parse(b);
+
+    expect(wireit.clean).toEqual({
+      command: 'rm *',
+    });
+  });
+});
diff --git a/packages/wireit-package/src/update.ts b/packages/wireit-package/src/update.ts
@@ -27,35 +27,33 @@ export async function update(args: UpdateArgs) {
 
     if (!packageData?.manifest.dependencies) continue;
 
+    const { manifest, absPath, manifestPath } = packageData;
+
+    if (!manifest.dependencies) continue;
+
     const dependencies: string[] = [];
-    const wireit = {
+    const wireit = (manifest['wireit'] as Record<string, unknown> | undefined) || {
       [name]: {
         command,
         dependencies,
       },
     };
 
-    for (const [dependencyName] of Object.entries(packageData.manifest.dependencies)) {
+    for (const [dependencyName] of Object.entries(manifest.dependencies)) {
       const dependencyPackage = result.packages[dependencyName];
 
       if (!dependencyPackage) continue;
 
-      const relative = path.posix.relative(
-        packageData.absPath,
-        dependencyPackage.absPath,
-      );
+      const relative = path.posix.relative(absPath, dependencyPackage.absPath);
 
       dependencies.push(`${relative}:${name}`);
     }
 
     if (dependencies.length > 0) {
-      packageData.manifest['wireit'] = wireit;
+      manifest['wireit'] = wireit;
     }
 
-    await fs.writeFile(
-      packageData.manifestPath,
-      JSON.stringify(packageData.manifest, undefined, 2),
-    );
+    await fs.writeFile(manifestPath, JSON.stringify(manifest, undefined, 2));
   }
 
   return result;