Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose underlying client instance #446

Merged
merged 13 commits into from
May 16, 2024
Merged

feat: expose underlying client instance #446

merged 13 commits into from
May 16, 2024

Conversation

xuzuodong
Copy link
Contributor

πŸ”— Linked issue

#210

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds instance key to all drivers.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@xuzuodong
Copy link
Contributor Author

I'm not able to add proper instance to mongodb though since it causes a build error because of this issue of unbuild.

@pi0
Copy link
Member

pi0 commented May 16, 2024

Feel free to add for mongo too will try to fix build issue

src/drivers/fs-lite.ts Outdated Show resolved Hide resolved
src/drivers/fs.ts Outdated Show resolved Hide resolved
src/drivers/github.ts Outdated Show resolved Hide resolved
src/drivers/http.ts Outdated Show resolved Hide resolved
src/drivers/indexedb.ts Outdated Show resolved Hide resolved
src/drivers/overlay.ts Outdated Show resolved Hide resolved
src/drivers/utils/index.ts Outdated Show resolved Hide resolved
@xuzuodong xuzuodong requested a review from pi0 May 16, 2024 10:16
test/drivers/utils.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
@xuzuodong xuzuodong requested a review from pi0 May 16, 2024 12:06
src/drivers/utils/index.ts Outdated Show resolved Hide resolved
src/drivers/memory.ts Outdated Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
xuzuodong and others added 2 commits May 16, 2024 20:23
Co-authored-by: Pooya Parsa <pyapar@gmail.com>
Co-authored-by: Pooya Parsa <pyapar@gmail.com>
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work, thanks!

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 89.85507% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 66.65%. Comparing base (4d61c78) to head (aa767f5).
Report is 48 commits behind head on main.

Files Patch % Lines
src/drivers/netlify-blobs.ts 87.87% 8 Missing ⚠️
src/drivers/vercel-kv.ts 0.00% 5 Missing ⚠️
src/drivers/planetscale.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   65.05%   66.65%   +1.60%     
==========================================
  Files          39       39              
  Lines        4055     4127      +72     
  Branches      487      511      +24     
==========================================
+ Hits         2638     2751     +113     
+ Misses       1408     1367      -41     
  Partials        9        9              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 merged commit d23cba5 into unjs:main May 16, 2024
4 checks passed
@xuzuodong
Copy link
Contributor Author

@pi0 Hi! Would it be possible to release a new version soon to include this? I'm eagerly looking forward to using them in my project. Thanks in advance 🫢

@pi0
Copy link
Member

pi0 commented May 21, 2024

Surely. it might be delayed for a little longer since is in parallel to other releases.

@pi0 pi0 mentioned this pull request Dec 18, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants