Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setItems): call driver native setItems only to avoid duplicate write #392

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

juliusmarminge
Copy link
Contributor

@juliusmarminge juliusmarminge commented Jan 30, 2024

πŸ”— Linked issue

#390 (comment)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The setItems function first calls the setItems, and the setItem for each element.

This is the test result before the change:

CleanShot 2024-01-30 at 13 12 25@2x

and this is after:

CleanShot 2024-01-30 at 13 14 21@2x

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@juliusmarminge juliusmarminge mentioned this pull request Jan 30, 2024
8 tasks
@pi0 pi0 changed the title fix: setItems uploads elements twice fix(setItems): call driver native setItems only to avoid duplicate write Mar 14, 2024
@pi0 pi0 merged commit 85bdbb7 into unjs:main Mar 14, 2024
@pi0
Copy link
Member

pi0 commented Mar 14, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants