feat: add deno-kv driver
#233
Conversation
There was a problem hiding this comment.
Thanks for the PR @so1ve !
It's missing documentation and tests.
We also might have some issues testing this with the CI. Maybe we can stub or mock DenoKV, or run the Deno test alone.
|
I can add documentation for it, but I'm not sure how to test :( Maybe just simply run deno alone? |
You can try a similar approach to here https://github.com/unjs/nitro/blob/main/test/presets/deno-server.test.ts |
|
I wrote this test on so1ve#10. |
* fix(prefixStorage): prefix `getItemRaw` and `setItemRaw` (unjs#232) * fix(github): fetchFiles should return files (unjs#229) * chore(deps): update all non-major dependencies (unjs#220) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update eslint * test: skip cloudflare-kv-http on node >= 18 * chore(release): v1.6.1 * docs: add social share image * chore: update deps * docs: fix typo (unjs#239) Change `environemnt` to `environment` Update cloudflare-kv-http.md * chore: update dependencies * feat: generic type support (unjs#237) * refactor: fix issues with typescript strict (unjs#250) * chore: add type check to ci * ci: skip flaky azure tests * chore(release): v1.7.0 * chore(deps): update all non-major dependencies * docs: fix typo (unjs#252) * chore(deps): update all non-major dependencies * test: add test for `github` driver (unjs#259) * feat: experimental operation batching (unjs#240) Co-authored-by: Pooya Parsa <pooya@pi0.io> * feat(cloudflare-kv): support `base` option for keys (unjs#261) * feat: `cloudflare-r2-binding` driver (unjs#235) * fix: add missing `cloudflareR2Binding` to the `builtinDrivers` * chore: update dev dependencies * chore(release): v1.8.0 * Fix typescript checks * add typehint * Install execa * Write test code * Remove not using import --------- Co-authored-by: 魔王少年 <q267009886.work@gmail.com> Co-authored-by: Andrei Dyldin <and@cesbo.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Pooya Parsa <pooya@pi0.io> Co-authored-by: Sébastien Chopin <seb@nuxt.com> Co-authored-by: Neelansh Mathur <53081208+neelansh15@users.noreply.github.com> Co-authored-by: 魔王少年 <q267009886.tw@gmail.com> Co-authored-by: Alex Duval <alexduval71@gmail.com> Co-authored-by: Hebilicious <xsh4k3@gmail.com>
✅ Live Preview ready!
|
There was a problem hiding this comment.
Testing with Deno can be complicated, so I'm not sure we should do more. @pi0 will review it
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
- Coverage 65.05% 60.34% -4.72%
==========================================
Files 39 38 -1
Lines 4055 3311 -744
Branches 487 557 +70
==========================================
- Hits 2638 1998 -640
+ Misses 1408 1309 -99
+ Partials 9 4 -5 ☔ View full report in Codecov by Sentry. |
|
Thanks again for the PR. I have worked on implementation updates (mainly in b79cf2e), updated tests to run all of the test-suit, and added initial docs, we can move it forward now! |
close #224
continue #227