fix: patch tests to make URL work #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuiiBz
approved these changes
Mar 15, 2024
Deploying runtime-compat with
|
| Latest commit: |
c319e84
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://830841ef.runtime-compat.pages.dev |
| Branch Preview URL: | https://patch-request.runtime-compat.pages.dev |
ascorbic
commented
Mar 15, 2024
| @@ -9,7 +9,7 @@ | |||
| "build": "unbuild", | |||
| "start-server": "wasmer run wasmer/winterjs --net --env PORT=7070 --mapdir dist:dist dist/handler.mjs", | |||
| "run": "curl -o data.json http://127.0.0.1:7070", | |||
| "start": "start-server-and-test start-server http://127.0.0.1:7070 run" | |||
| "start": "echo skipping wasmer # start-server-and-test start-server http://127.0.0.1:7070 run" | |||
There was a problem hiding this comment.
There seems to be an issue with WinterJS right now that's causing it to hang in GH actions. I'm skipping it for now, meaning it won't update the tests for it automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes #45
❓ Type of change
📚 Description
Manually applies openwebdocs/mdn-bcd-collector#1295 to the tests so that the URL and Request tests an run
📝 Checklist