Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return ParsedTarFileItem type after parsing #21

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

bluwy
Copy link
Contributor

@bluwy bluwy commented Oct 22, 2024

The return type of parseTar and parseTarGzip should be using ParsedTarFileItem as that's what being computed in the functions:

nanotar/src/parse.ts

Lines 3 to 6 in c1247bd

export function parseTar(data: ArrayBuffer | Uint8Array): TarFileItem[] {
const buffer = (data as Uint8Array).buffer || data;
const files: ParsedTarFileItem[] = [];

return files;

@pi0 pi0 changed the title fix(parse): return ParsedTarFileItem fix: return ParsedTarFileItem type after parsing Jan 20, 2025
@pi0 pi0 merged commit 9712a24 into unjs:main Jan 20, 2025
@bluwy bluwy deleted the fix-parse-return-type branch January 20, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants