fix(vue): transpile vue template #289
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 82.86% 84.33% +1.47%
==========================================
Files 12 13 +1
Lines 852 1079 +227
Branches 133 231 +98
==========================================
+ Hits 706 910 +204
- Misses 144 167 +23
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
i wonder if this will also fix a bug i haven't yet had time to report here (can be reproduced in nuxt/image repo) it was compiling nuxtimg component to reference properties in the template that were not exposed from setup |
I built it with The pr just remove ts syntax from vue template so it should has no effect to this.
Vue expose all props and variables defined in |
|
you can replicate by running |
I replicated it, minimal reproduction vue playground <script>
import { defineComponent } from "vue";
export default defineComponent({
setup() {
const isServer = true;
const __returned__ = { isServer };
Object.defineProperty(__returned__, "__isScriptSetup", { enumerable: false, value: true });
return __returned__;
}
});
</script>
<template>
{{ isServer || 'nothing here' }}
</template>once I removed Then I found the description about __isScriptSetup: compileScript.ts
This is weird, according to the comments it should expose more stuff. But later I found this: const hasSetupBinding = (state: Data, key: string) =>
state !== EMPTY_OBJ && !state.__isScriptSetup && hasOwn(state, key)It looks like we also need to compile the template and get these variables in |
|
Now it seems a bit of a dilemma:
|
|
now for files with no As for point 2 in #289 (comment), I think make our own transpiler requires thousands lines of code to handling edge cases, it would be better to make it in upstream if we really want. Tested with nuxt/image, now it passed all test. build log |
resolves #281
Transpile vue template if the file have a typescript script block