-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vue): refactor vue loader with vue/compiler-sfc #251
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
==========================================
- Coverage 82.86% 80.11% -2.76%
==========================================
Files 12 12
Lines 852 890 +38
Branches 133 189 +56
==========================================
+ Hits 706 713 +7
- Misses 144 175 +31
Partials 2 2 ☔ View full report in Codecov by Sentry. |
now fixed |
@Teages This is a nice workaround! Since the PR hasn't received reviews for 1 month, can you temporarily release this fork to NPM? |
@typed-sigterm the package is avalibale on {
"devDependencies": {
"mkdist": "npm:@teages/mkdist@1.6.0-patch.251"
}
} or: {
"resolutions": {
"mkdist": "npm:@teages/mkdist@1.6.0-patch.251",
}
} It works with the main branch of |
Refactor the vue loader with vue/compiler-sfc.
Resolve #209 #249 #243 #14 #15
Close #210
Some break changes:
<script setup lang="*">
, but they are still human readableBut I think it is worth.
also updated test.
It is a draft pull request because I found some timesvue-tsc^2.1.0
will add the vue global declare in dts output for no resaon.It happens in my own package Teages/mkdist-vue-loader but after I merged back to mkdist it disappeared....fixed with 31e93f0
tested with 2452db9
Example