Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fixed cleanDist with addition of --no-clean option #217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

metaory
Copy link

@metaory metaory commented Apr 25, 2024

πŸ”— Linked issue

#216 The option cleanDist was never added to args of citty

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

❌ every build is cleaning the dist/

I'm aware the cleanDist option was added on:
f613c17 support cleanDist option was added by @pi0 long time ago

⚠️ but no cli arg was ever added

This PR Resolves #216
It add a new optional cli arg --no-clean when provided the make function wont clean the dist path
Default behavior continues as before, with clean being true

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The option cleanDist was never added to args of citty
1 participant