fix!: writeFile
now requires filename
#79
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
fix #66
close #76
β Type of change
π Description
This PR solve a type issue and add some tests.
And because
recast
, https://github.com/benjamn/recast/blob/master/lib/parser.ts#L24, does not pass the filename to the parser option, we can't use it as the output filename.I'm not sure if how tests are written is the best way to do it, so feel free to change it if you have a better idea.
π Checklist