feat: deepMergeObject improvements; NumericLiteral and StringLiteral keys #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tahul
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey; this is a follow-up of #62
This also fixes remaining parts of: https://github.com/nuxtlabs/studio-api/issues/730
This adds support for
NumericLiteralandBooleanLiteralkeys onproxifyObject.If you run the first commit, you'll see that the test merges two of the same keys into two different ones in the object.
That can have unexpected behavior when generating the code from this.
I'm not sure about the fix, but it seem to be getting the expected result without breaking any other test.
It might be worth writing other tests for
proxifyObjectto ensure I did not break any other usage with these changes, could you let me know if you have ideas of such cases?