-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use citty for cli #113
Conversation
07d1545
to
a3f67f7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
- Coverage 62.45% 59.84% -2.61%
==========================================
Files 7 7
Lines 506 528 +22
Branches 44 44
==========================================
Hits 316 316
- Misses 189 211 +22
Partials 1 1 β View full report in Codecov by Sentry. |
src/commands/copy.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can avoid breaking change by having it in main. I will help on that in the meanwhile, i think we can call it clone
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've named it "copy" to avoid "clone" which is for git where the git history is also copied.
And yes, I would love some help because I don't know you to avoid breaking change since run is called after a subcommand is called.
π Linked issue
β Type of change
π Description
I rewrite CLI to use citty instead of a home made CLI. The only drawback is that we now need to specify "clone" to clone a template from a registry and that's why it's a breaking change.
This will help use to maintain the CLI and add new features more easily. Indeed, we will be able to add new commands to support multiple registries.
Here what could come next:
Then, with some changes in the internal logic, we could support multiple registries at the same time (related to #112).
π Checklist