Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update exports for node16 typescript resolution #331

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Dec 27, 2024

resolves #324

add nested export conditions to be more friendly with typescript node16 resolution and use explicit cjs/mjs extensions.

this change was introduced in 18bc852 / 3.3.2 which caused a regression (#329) because of backward compatibility of libraries that depend on cjs + default export of consola (952b961 fixes it by using compat entry for exports.node.require.default condition.

@pi0 pi0 changed the title build/exports build: update exports for node16 typescript resolution Dec 27, 2024
@pi0 pi0 merged commit 9442ffb into main Dec 27, 2024
2 checks passed
@pi0 pi0 deleted the build/exports branch December 27, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to import package under node16 module resolution mode
1 participant