Replace complex m4 builtins in configure.ac with suitable AS_TR_CPP #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mostly LGTM, see small remarks above. And indeed using |
Preparing for following commits.
autoconf provides 'm4_'-prefixed alias macros for m4 builtin macros, and original non 'm4_'-prefixed macros are not recommended.
AS_TR_CPP first appeared in autoconf-2.50a (2001-06-26).
p-montanus
force-pushed
the
fix-configure-replace-complex-m4-builtins-with-suitable
branch
from
696d79b to
f5d8177
Compare
|
Thank you for reviewing: Revised. |
|
LGTM, thanks :) One remark, maybe the middle commit is not useful as all its changes are actually removed in the next one. But that's not important, it's a valid step anyway. |
|
Yes, middle commit is just informational. |
|
fair enough :] |
b4n
added a commit
that referenced
this pull request
Sep 27, 2015
…-m4-builtins-with-suitable Replace complex m4 builtins in configure.ac with suitable AS_TR_CPP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In configure.ac, some m4 builtins are used directory.
autoconf provides 'm4_'-prefixed alias macros for m4 builtin macros, and original non 'm4_'-prefixed macros are not recommended. Equivalent AS_TR_CPP provided by autoconf is more suitable rather than complex these m4 builtins.
AS_TR_CPP first appeared in autoconf-2.50a (2001-06-26).
autoreconf-2.59 and autoreconf-2.69 with '-Wall' report no warnings.