-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Haskell parser from Geany #2712
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2712 +/- ##
==========================================
+ Coverage 87.00% 87.01% +0.01%
==========================================
Files 190 191 +1
Lines 40450 40619 +169
==========================================
+ Hits 35192 35346 +154
- Misses 5258 5273 +15
Continue to review full report at Codecov.
|
Can I ask you to provide a test case for LiterateHaskell? |
8632b08
to
b01f04b
Compare
Yeah, same here. Not sure if anyone is crazy enough to use it: |
22247e3
to
108f4fa
Compare
If Haskel code is embedded in latex code, I think using Tex parser will be better.
But the Haskel parser is obviously useful. So I will merge this PR in soon. I should not make you wait for more. |
The question really is whether the literate haskell part is any useful and whether it shouldn't be removed completely. I can't really imagine that anyone would code this way. |
I've just checked and in Geany we don't use the literate haskell part. Personally, I'd just remove it. Should I do it? |
No, you don't need to remove it. Instead, could you resolve the conflict? |
Noticed because the part after the if wasn't executed in the coverage test. This happened because 'token' wasn't updated.
dcd3021
to
3be0d41
Compare
Thank you very much. |
Haskell https://en.wikipedia.org/wiki/Haskell_%28programming_language%29