Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Haskell parser from Geany #2712

Merged
merged 2 commits into from
Dec 5, 2020

Conversation

techee
Copy link
Contributor

@techee techee commented Nov 19, 2020

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #2712 (3be0d41) into master (8d0f6d5) will increase coverage by 0.01%.
The diff coverage is 91.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2712      +/-   ##
==========================================
+ Coverage   87.00%   87.01%   +0.01%     
==========================================
  Files         190      191       +1     
  Lines       40450    40619     +169     
==========================================
+ Hits        35192    35346     +154     
- Misses       5258     5273      +15     
Impacted Files Coverage Δ
parsers/haskell.c 91.12% <91.12%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0f6d5...3be0d41. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 19, 2020

Coverage Status

Coverage increased (+0.02%) to 87.1% when pulling 3be0d41 on techee:geany_haskell_parser into 8d0f6d5 on universal-ctags:master.

@masatake
Copy link
Member

Can I ask you to provide a test case for LiterateHaskell?
This is the first time to hear about it.

@techee techee force-pushed the geany_haskell_parser branch from 8632b08 to b01f04b Compare November 24, 2020 20:21
@techee
Copy link
Contributor Author

techee commented Nov 24, 2020

This is the first time to hear about it.

Yeah, same here. Not sure if anyone is crazy enough to use it:

https://www.haskell.org/onlinereport/literate.html

@techee techee force-pushed the geany_haskell_parser branch 3 times, most recently from 22247e3 to 108f4fa Compare November 26, 2020 18:14
@masatake masatake self-assigned this Nov 26, 2020
@masatake
Copy link
Member

masatake commented Nov 29, 2020

If Haskel code is embedded in latex code, I think using Tex parser will be better.
Real lhs language processor may just ignore Latex code part.
However, ctags should make tags for the Latex code part, too.

Give me time.

But the Haskel parser is obviously useful. So I will merge this PR in soon. I should not make you wait for more.

@techee
Copy link
Contributor Author

techee commented Nov 29, 2020

The question really is whether the literate haskell part is any useful and whether it shouldn't be removed completely. I can't really imagine that anyone would code this way.

@techee
Copy link
Contributor Author

techee commented Nov 29, 2020

I've just checked and in Geany we don't use the literate haskell part. Personally, I'd just remove it. Should I do it?

@masatake
Copy link
Member

masatake commented Nov 29, 2020

I've just checked and in Geany we don't use the literate haskell part. Personally, I'd just remove it. Should I do it?

No, you don't need to remove it.

Instead, could you resolve the conflict?

Noticed because the part after the if wasn't executed in the coverage
test. This happened because 'token' wasn't updated.
@techee techee force-pushed the geany_haskell_parser branch from dcd3021 to 3be0d41 Compare November 29, 2020 16:29
@masatake masatake merged commit e64d7b8 into universal-ctags:master Dec 5, 2020
@masatake
Copy link
Member

masatake commented Dec 5, 2020

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants