main: Handle empty HOME, HOMEDRIVE, and HOMEPATH envvar #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masatake
changed the title
Suggested by @itchyny in universal-ctags#2384. When $HOME is set but it is an empty string,
…d file name combinePathAndFile takes two C strings. The first one PATH was used in an expression: path [strlen(path) - 1] . If PATH is an empty, this can cause a buffer overrun. This change adds a guard-condition for such processing. Inspired from the comment submitted by @itchyny in universal-ctags#2384.
…PATH are empty Inspired from the comment submitted by @itchyny in universal-ctags#2384.
masatake
force-pushed
the
handle-empty-HOME-envvar
branch
from
610d1fe to
41bb8fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #2385 +/- ##
==========================================
+ Coverage 86.25% 86.25% +<.01%
==========================================
Files 176 176
Lines 35740 35742 +2
==========================================
+ Hits 30828 30830 +2
Misses 4912 4912
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2384 (comment) .
No test case. I cannot find a way to write a test case for Tmain easily.