-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pascal: Parse first type
identifier
#2241
base: master
Are you sure you want to change the base?
Conversation
Test cases under review-needed.r were imported from exuberant-ctags. If you know Pascal, I would like you to review the test case first. |
Test case looks fine.
This pull will modify the tags generated by the existing test case. All I did was add a function. |
Your work is nothing to do with bug612019.pas, isn't it? |
Although the procedures and function (which I added) should maybe have an empty parameter list. |
It has a type declaration. |
Do you mean the original test input has a type declaration, and so you reuse the test input for your work? |
@@ -1,3 +1,4 @@ | |||
Test1 input.pas /^ procedure Test1;$/;" p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test1 is not tagged with the change.
@ntrel reviewed the case in universal-ctags#2241. Thank you.
Close universal-ctags#2241. @mastake's note: This pull chnage is based on universal-ctags#2241 submitted by @ntrel. I adjust the change not to fill "signature" field for tags of "type" kind. I also adjust the change to avoid regression.
@ntrel reviewed the case in universal-ctags#2241. Thank you.
This is a change ported from Geany.
Needs tests.