Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docbook: new parser #2198

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Docbook: new parser #2198

wants to merge 4 commits into from

Conversation

masatake
Copy link
Member

After studying an docbook parser implementation proposed at #2106, I decided to take very different approach to implement the parser. See the comments in parsers/docbook.c.

There are two weaknesses.

  • Unlike Geany's one, this parser requires libxml2.
  • The input must be well-formed XML.

namespace of XML is not handled well. I have to study how to handle the namespace in u-ctags.

@masatake
XML: pass cork indexes to sub parsers instead of pointers to tagEntry…
4bfe418 
…Info

This change is needed in planed docbook parser run as a sub parser
of XML parser.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake masatake requested a review from techee September 16, 2019 19:23
@masatake
DocBook: new parser (libxml2 based)
1a8dfec 
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake
Units,DocBook: import a test case from Geany
85b6b39 
The input is taken from universal-ctags#2106 submitted by @techee.
@masatake
Copy link
Member Author

@techee, sorry to be late. I'm merging #2106 incrementally.
If you have time, I would like to see the comment at the head of parsers/docbook.c.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 86.184% when pulling 85b6b39 on masatake:docbook into 126781c on universal-ctags:master.

@masatake
Copy link
Member Author

What a wonderful bug!

@masatake
Copy link
Member Author

The mechanism for choosing a parser is not enough to choose a suitable XML subparser.
selectParserForXmlDoc is called too early stage.
It should be called from the XML base parser.

I have to fix this.

@techee techee mentioned this pull request Apr 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techee techee Awaiting requested review from techee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masatake @coveralls