Defining interface for parsers (part 2 of N) #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masatake
force-pushed
the
cleanup-inclusions
branch
from
b4b3895 to
1d17923
Compare
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
In *.h files, don't include entry.h is is really needed. Include types.h instead. types.h exposes much limited interface than entry.h. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
To simplify the interface between main part and parsers, this change cleans up parse.h. All main's private items are moved to newly introduced parse_p.h header. Signed-off-by: Mastake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
cleanup-inclusions
branch
from
1d17923 to
8cbf052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1917.
As the result of adding features randomly, the main part of ctags is a bit mess.
I would like to start the process for cleaning.
The most dirty part is that we cannot know whether an extern'ed function is for parsers or the main part itself.
I would like to split header files in the main part into two groups.
Header files in group 2 should have following file name "foo_p.h".
The changes are so many. Therefore, I would like to do this cleaning up incrementally.
I would like to introduce
ctags_or something prefix in the symbols in the interface for the parsers.However, splitting the header files must be the first.
The most of changes have no impact on the parsers. They just change the name of header files and the order of inclusion.