Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXX: Fix #1750 (without breaking other unit tests) #1759

Merged
merged 2 commits into from
Jun 6, 2018
Merged

CXX: Fix #1750 (without breaking other unit tests) #1759

merged 2 commits into from
Jun 6, 2018

Conversation

pragmaware
Copy link
Contributor

Rather complicated, but fixes #1750 and does not break existing unit tests.
One can still construct tests that fool the parser. A definitive fix is not feasible without global knowledge
about the program being compiled.

@coveralls
Copy link

coveralls commented May 26, 2018

Coverage Status

Coverage decreased (-0.003%) to 84.9% when pulling 9fc990f on pragmaware:fix-bug-1750-attempt-2 into 7e087c5 on universal-ctags:master.

@masatake
Copy link
Member

Could you the two commits into one?
git rebase -i master may help you.

Could you rename the .b test case to .d? "make units" says at the end of output:

...
#FIXED:                                 3
	parser-cxx.r/template-nested-triangle-brackets
...

@pragmaware
Copy link
Contributor Author

pragmaware commented May 26, 2018

Done.

@masatake masatake self-requested a review May 26, 2018 18:31
@pragmaware
Copy link
Contributor Author

Do you still need to review this or we can merge?

@masatake
Copy link
Member

masatake commented Jun 4, 2018

I'm sorry to be late. I have had a troulbe in my health.

I have two requests you to change the commits.

  1. Could you remove the lines only whitespaces?
    git diff may tell where the lines are.

whitespace-only-lines

  1. Could you add a ".b" test case that ctags cannot handle well even with your new code?

ctags can handle your example well:

template<char i, bool B = i < 10> void f1(void) { }

I would like you to add paranoid but compilable ones because I would like to try my algorithm.

@masatake masatake removed their request for review June 4, 2018 09:30
@masatake
Copy link
Member

masatake commented Jun 6, 2018

LGTM. Thank you very much.

@pragmaware pragmaware merged commit 96d39e4 into universal-ctags:master Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

c++ parsing error
3 participants