Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsers: gcc warnings when configured with --enable-debugging #2286

Closed
k-takata opened this issue Oct 31, 2019 · 1 comment · Fixed by #2300
Closed

parsers: gcc warnings when configured with --enable-debugging #2286

k-takata opened this issue Oct 31, 2019 · 1 comment · Fixed by #2300

Comments

@k-takata
Copy link
Member

The following two warnings are shown when u-ctags is configured with --enable-debugging:

../parsers/html.c:189:13: warning: ‘dumpToken’ defined but not used [-Wunused-function]
 static void dumpToken (tokenInfo *token, const char *context, const char* extra_context)
             ^
../parsers/jscript.c:2617:13: warning: ‘dumpToken’ defined but not used [-Wunused-function]
 static void dumpToken (const tokenInfo *const token)
             ^

We can comment out these two functions with #if 0 ... #endif or completely remove them to suppress the warnings.
(Not sure which is better.)

@masatake masatake self-assigned this Nov 1, 2019
@masatake
Copy link
Member

masatake commented Nov 4, 2019

People may use the function for print-debuggnig. So wrapping #if 0/#endif may be better.

@masatake masatake removed their assignment Nov 4, 2019
k-takata added a commit to k-takata/ctags that referenced this issue Nov 4, 2019
k-takata added a commit to k-takata/ctags that referenced this issue Nov 4, 2019
k-takata added a commit to k-takata/ctags that referenced this issue Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants