Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize extra LRE functions to work with all QPROGRAMs #2599

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

natestemen
Copy link
Member

Description

Quick fix to ensure the LRE module is compatible with all QPROGRAM instances.

fixes #2584

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (7648648) to head (db1b393).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2599   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files          92       92           
  Lines        4174     4176    +2     
=======================================
+ Hits         4121     4123    +2     
  Misses         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

typehint reflects pre-decorator function, not post.
Copy link
Collaborator

@purva-thakre purva-thakre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wonder if we should make sure other public functions in LRE also have a similar compatibility?

I see sample_matrix only works for Cirq circuits.

def sample_matrix(
input_circuit: Circuit,

@natestemen
Copy link
Member Author

I wonder if we should make sure other public functions in LRE also have a similar compatibility?

Good call, added db1b393 to address sample_matrix.

@natestemen natestemen changed the title Generalize get_scale_factor_vectors to work with all QPROGRAMs Generalize extra LRE functions to work with all QPROGRAMs Dec 11, 2024
@natestemen natestemen merged commit 85a8418 into main Dec 11, 2024
18 checks passed
@natestemen natestemen deleted the lre-qprogram-bug branch December 11, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LRE error with qiskit circuit
2 participants