-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove make requirements
#2481
Remove make requirements
#2481
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2481 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 88 88
Lines 4091 4091
=======================================
Hits 4038 4038
Misses 53 53 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprised this isn't in the documentation! I guess that's part of the reason we aren't using it 😆.
Side note: the macos runners ran all the unit tests in <5 min! Not sure if they are getting faster, or if I've never noticed that before. Cool.
@natestemen You suggested we remove |
By "in the docs" I mean in the contributing documentation, rather than the build systems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks – good finding
Description
As discussed in #2441 (comment)
License
Before opening the PR, please ensure you have completed the following where appropriate.