Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing section in classical shadows example #2026

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

Min-Li
Copy link
Contributor

@Min-Li Min-Li commented Sep 23, 2023

Description

Somehow a section has been deleted from the previous version, adding some docstrings


License

  • I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

@Min-Li Min-Li added this to the 0.30.0 milestone Sep 23, 2023
@Min-Li Min-Li self-assigned this Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (be87d6f) 98.28% compared to head (cffc555) 98.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2026   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          86       86           
  Lines        4084     4084           
=======================================
  Hits         4014     4014           
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreamari andreamari changed the title Add doc strings, the current version is lack of a section. Add missing section in classical shadows example Sep 25, 2023
Copy link
Member

@andreamari andreamari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Min-Li for catching and fixing the problem!

@andreamari andreamari merged commit 8ad05ea into unitaryfund:master Sep 25, 2023
20 checks passed
@Min-Li
Copy link
Contributor Author

Min-Li commented Sep 25, 2023

Thanks for checking this out so fast @andreamari!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants